-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow Custom Property Update in Glossary Bulk Import/export #17919
Merged
Merged
Changes from 7 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
1ec2981
fix import issue
chirag-madlani b90026b
Merge remote-tracking branch 'origin/main'
sonika-shah 0f25edd
Merge remote-tracking branch 'origin/main'
sonika-shah 4c0441a
Merge remote-tracking branch 'origin/main'
sonika-shah 564967a
Merge remote-tracking branch 'origin/main'
sonika-shah 8708738
Feat : Allow Custom Property Update in Bulk Upload
sonika-shah 58fc964
Feat : Allow Custom Property Update in Bulk Upload
sonika-shah ac8a4cb
Merge remote-tracking branch 'origin/main'
sonika-shah 80c533d
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 65ed612
Merge branch 'main' into feature-import-export-custom-property
sonika-shah 4bb8473
Merge remote-tracking branch 'origin/main'
sonika-shah 1d165d1
Merge remote-tracking branch 'origin/main'
sonika-shah e46696b
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 04ea4bc
supported editable imports in glossary page
Ashish8689 4d918fb
added remaning localizaion keys
Ashish8689 290bbeb
Merge remote-tracking branch 'origin/main'
sonika-shah 7584eec
Merge branch 'main' into feature-import-export-custom-property
sonika-shah c498c87
update logic of fieldToExtensionStrings to use csvparser
sonika-shah f2d35f5
Merge remote-tracking branch 'origin/feature-import-export-custom-pro…
sonika-shah 410a067
update json and partialStatus condition
sonika-shah e87b156
Merge remote-tracking branch 'origin/feature-import-export-custom-pro…
sonika-shah c1793fd
fix tests for partialSuccess status change
sonika-shah a8ba567
Merge remote-tracking branch 'origin/feature-import-export-custom-pro…
sonika-shah 4601f20
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 482e35f
supported customProperty editable field
Ashish8689 118f309
Merge remote-tracking branch 'origin/feature-import-export-custom-pro…
sonika-shah 6ec8eb9
fix error in custom property edit modal on new line empty custom prop…
Ashish8689 e07f90d
Merge remote-tracking branch 'origin/feature-import-export-custom-pro…
sonika-shah b4a8f51
added entity type from root to support other bulk import entity as well
Ashish8689 de71b78
fix the quote removing due to the regex in the string type
Ashish8689 9fbde3c
Merge remote-tracking branch 'origin/feature-import-export-custom-pro…
sonika-shah e5176f9
Add backend tests , and error msg improvements
sonika-shah 4751990
GlossaryStatus header change
mohityadav766 e1e66ab
Merge remote-tracking branch 'origin/feature-import-export-custom-pro…
mohityadav766 0c70baa
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 7d8cf84
fix unit test and dry run in case of synonyms having quotes in it
Ashish8689 dde2c0b
Remove extension column in CSVs for all entities except glossaryTerm
sonika-shah 7a4500b
added editor for reviewers
Ashish8689 ce47405
unit test around csv utils
Ashish8689 998efe8
added escape for string too, in case of semicolon comes
Ashish8689 784f2b5
added playwright test without extension and supported relatedTerm as …
Ashish8689 70dd468
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 01ec59d
added unit test around csv util logic
Ashish8689 9228945
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 eaa9e86
resolve conflicts
sonika-shah bf56784
Merge branch 'main' into feature-import-export-custom-property
sonika-shah c2457bb
Backend - add support for enumWithDescriptions in bulk import
sonika-shah e4fb9d7
add tests and other error handling improvements related to enumWithDe…
sonika-shah 1e25a5c
fix the custom property modal header and render the layout as per rig…
Ashish8689 4f4e26e
parese enumWithDescription for the customProperty modal while editable
Ashish8689 94b8515
fix description data in enumWithDescription one
Ashish8689 6ad168a
fix: Handle NullPointerException when adding custom properties to ens…
sonika-shah 1986cf0
added extension playwrigth test and fix enumWithDescription object fa…
Ashish8689 4600bf0
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 354ffb3
descrease the size of extension modal
Ashish8689 24dba51
remove additional comments
sonika-shah addac1a
fix the escape in parent key
Ashish8689 9a9599b
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 779bed7
improve custom property layout
Sachin-chaurasiya 2162217
improve ui for inline properties
Sachin-chaurasiya 9734649
fix description, glossary and relatedTerm escape char issue
Ashish8689 eec45d4
fix some customProperty ui changes
Ashish8689 fd21170
fix sonar issue
Ashish8689 f6830cb
Merge branch 'main' into feature-import-export-custom-property
Ashish8689 305b92d
minor layout changes
Sachin-chaurasiya 6da7ccb
minor label improvements for entity ref and list
Sachin-chaurasiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove these comments.
can we add some mocks to test this part of code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated logic of fieldToExtensionStrings to use CSVParser with added tests