Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Apply multi threading in View Lineage Processing #17922

Merged
merged 1 commit into from
Sep 19, 2024
Merged

MINOR: Apply multi threading in View Lineage Processing #17922

merged 1 commit into from
Sep 19, 2024

Conversation

ulixius9
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ulixius9 ulixius9 requested a review from a team as a code owner September 19, 2024 11:18
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 19, 2024
ulixius9
ulixius9 commented Sep 19, 2024
View reviewed changes
ingestion/src/metadata/ingestion/source/database/snowflake/metadata.py
@@ -148,7 +145,6 @@


class SnowflakeSource(
LifeCycleQueryMixin,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabling lifecycle processing for snowflake

@pmbrull pmbrull merged commit 1be2382 into main Sep 19, 2024
7 of 15 checks passed
@pmbrull pmbrull deleted the multi_thread_views branch September 19, 2024 13:06
ulixius9 added a commit that referenced this pull request Sep 19, 2024
@ulixius9
MINOR: Apply multi threading in View Lineage Processing (#17922)
eda9ecc
ulixius9 added a commit that referenced this pull request Sep 19, 2024
@ulixius9
MINOR: Apply multi threading in View Lineage Processing (#17922)
1437bab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulixius9 @pmbrull