Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Saml Redirect Uri #17936

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Adds Saml Redirect Uri #17936

merged 9 commits into from
Sep 23, 2024

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Sep 20, 2024 •
edited
Loading

Describe your changes:

  • Add Session Manager to SAML
  • Add Redirect Uri PAram to allow redirection

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Sep 20, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner September 20, 2024 07:19
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Sep 20, 2024
pmbrull
pmbrull previously approved these changes Sep 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.33% (37394/58125) 40.97% (14810/36148) 43.09% (4511/10469)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mohityadav766 mohityadav766 merged commit d77cf36 into main Sep 23, 2024
22 of 26 checks passed
@mohityadav766 mohityadav766 deleted the fix-saml branch September 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@pmbrull pmbrull pmbrull left review comments

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohityadav766 @chirag-madlani @pmbrull @karanh37