Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: fix custom property playwright test for AUT #17937

Merged
merged 1 commit into from
Sep 20, 2024
Merged

minor: fix custom property playwright test for AUT #17937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/customProperty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,10 @@ export const addCustomPropertiesForEntity = async ({
// Enum configuration
if (customType === 'Enum' && enumConfig) {
for (const val of enumConfig.values) {
await page.fill('#root\\/enumConfig', `${val}{Enter}`);
await page.click('#root\\/enumConfig');
await page.fill('#root\\/enumConfig', val);
await page.press('#root\\/enumConfig', 'Enter');
await page.mouse.click(0, 0);
}

if (enumConfig.multiSelect) {
Expand Down Expand Up @@ -615,16 +618,17 @@ export const editCreatedProperty = async (
await page.locator(descriptionBox).fill('This is new description');

if (type === 'Enum') {
await page
.locator('#root\\/customPropertyConfig')
.fill(`updatedValue{Enter}`);
await page.click('body'); // Equivalent to clicking outside
await page.click('#root\\/customPropertyConfig');
await page.fill('#root\\/customPropertyConfig', 'updatedValue');
await page.press('#root\\/customPropertyConfig', 'Enter');
await page.mouse.click(0, 0);
}

if (ENTITY_REFERENCE_PROPERTIES.includes(type ?? '')) {
await page.locator('#root\\/customPropertyConfig').click();
await page.locator('#root\\/customPropertyConfig').fill(`Table{Enter}`);
await page.click('body'); // Equivalent to clicking outside
await page.click('#root\\/customPropertyConfig');
await page.fill('#root\\/customPropertyConfig', 'Table');
await page.press('#root\\/customPropertyConfig', 'Enter');
await page.mouse.click(0, 0);
}

const patchRequest = page.waitForResponse('/api/v1/metadata/types/*');
Expand Down
Loading