Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): GEN-1523 exclude defaultPersona if not present in personas #17940

Merged
merged 4 commits into from
Sep 21, 2024
Merged

fix(ui): GEN-1523 exclude defaultPersona if not present in personas #17940

merged 4 commits into from
Sep 21, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Sep 20, 2024 •
edited
Loading

Describe your changes:

Fixes: GEN-1523 #17885

  • Redshift flakiness for AUT tests
  • Data insight spec flakiness for AUT
  • Persist issue with defaultPersona even after removing from persona list

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@notion-workspace Notion Workspace
Copy link

backend: default persona persisted even after persona is removed

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.33% (37384/58115) 40.97% (14810/36148) 43.07% (4509/10468)

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit c1a4f48 into main Sep 21, 2024
13 of 16 checks passed
@chirag-madlani chirag-madlani deleted the fix-GEN-1523 branch September 21, 2024 05:46
chirag-madlani added a commit that referenced this pull request Sep 21, 2024
@chirag-madlani
fix(ui): GEN-1523 exclude defaultPersona if not present in personas (#…
fc4dc8d 
…17940)

(cherry picked from commit c1a4f48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @ShaileshParmar11