MINOR: fix snowflake system metrics #17989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceS2
previously approved these changes
Sep 25, 2024
TeddyCr
reviewed
Sep 25, 2024
ingestion/src/metadata/utils/dict.py
Outdated
Comment on lines
1
to
3
| class CustomDict(dict): | ||
| def lower_case_keys(self): | ||
| return {k.lower(): v for k, v in self.items()} |
There was a problem hiding this comment.
I don't think we need to make that an object right? I think it is a small overhead we can remove -- i.e. the object creation.
There was a problem hiding this comment.
Can you clarify? what needs to be an object?
github-actions
bot
added
Ingestion
safe to test
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
fixed the dq cli test
sushi30
requested review from
akash-jain-10,
harshach and
tutte
as code owners
akash-jain-10
approved these changes
Sep 26, 2024
IceS2
approved these changes
Sep 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
manual runs: https://github.com/open-metadata/OpenMetadata/actions/workflows/py-cli-e2e-tests.yml?query=branch%3Afix-snowflake-profiler
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>