Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add ingestion tag for playwright tests #18015

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Minor: Add ingestion tag for playwright tests #18015

merged 2 commits into from
Sep 26, 2024

Conversation

aniketkatkar97
Copy link
Member

I worked on adding the ingestion tag for all the playwright specs that require the ingestion container to be running

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues e2e This will trigger e2e test workflows labels Sep 26, 2024
@aniketkatkar97 aniketkatkar97 self-assigned this Sep 26, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.39% (37431/58136) 41.1% (14874/36187) 43.14% (4515/10466)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 423e99f into main Sep 26, 2024
15 of 16 checks passed
@chirag-madlani chirag-madlani deleted the ingestion-spec-tagging branch September 26, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@aniketkatkar97 aniketkatkar97

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketkatkar97 @chirag-madlani