Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: fix custom property layout issues #18065

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Oct 1, 2024

Describe your changes:

  • fix custom property layout issues around cards title and values
  • Remove description from right panel custom properties.
  • Reduce the description to one line
  • Make redirect entity link as link color for better visibility.
  • Change the expand icon to resemble what we use in the project.
  • Remove the custom property title in the Tab page.
image image image image
Screen.Recording.2024-10-01.at.3.41.33.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.14% (37684/58750) 40.9% (15016/36712) 42.94% (4540/10574)

Copy link

sonarqubecloud bot commented Oct 1, 2024

@chirag-madlani chirag-madlani merged commit 819c405 into main Oct 1, 2024
16 checks passed
@chirag-madlani chirag-madlani deleted the custom-property-layout-fix branch October 1, 2024 12:21
Ashish8689 added a commit that referenced this pull request Oct 1, 2024
* fix custom property layout issues

* fix font weight to similar like other

* fix the right panel value style issue

* fix the edit button alignment issue

* changes as per comments and sonar fix
Sachin-chaurasiya added a commit that referenced this pull request Oct 3, 2024
RounakDhillon pushed a commit to RounakDhillon/OpenMetadata that referenced this pull request Oct 3, 2024
* fix custom property layout issues

* fix font weight to similar like other

* fix the right panel value style issue

* fix the edit button alignment issue

* changes as per comments and sonar fix
Sachin-chaurasiya pushed a commit that referenced this pull request Oct 7, 2024
* fix custom property layout issues

* fix font weight to similar like other

* fix the right panel value style issue

* fix the edit button alignment issue

* changes as per comments and sonar fix

(cherry picked from commit 819c405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants