Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-1552: Postgres stored procedures support #18083

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

harshsoni2024
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

Comment on lines 311 to 317
POSTGRES_GET_STORED_PROCEDURES_QUERIES = """
SELECT
total_exec_time,
query
FROM pg_stat_statements
WHERE query LIKE 'CALL%';
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not want the query which calls sp, we will not be able to extract queries that were executed during sp execution so lets just add a comment for that and skip this query call.

Copy link

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions
28.8% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@harshsoni2024 harshsoni2024 requested a review from ulixius9 October 4, 2024 04:23
@ulixius9 ulixius9 merged commit 421ad60 into open-metadata:main Oct 7, 2024
15 of 16 checks passed
@harshsoni2024 harshsoni2024 deleted the gen-1552 branch December 19, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants