Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ServiceConnectionDetails component #18100

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ayush-shah
Copy link
Member

@ayush-shah ayush-shah commented Oct 3, 2024

Custom Logic for the Pipeline scoped to Airflow

Describe your changes:

Fixes an error where other pipeline connectors with connection attribute fails because of the custom logic for airflow connector

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.18% (37782/58865) 40.95% (15072/36810) 42.97% (4551/10592)

@ayush-shah ayush-shah marked this pull request as ready for review October 7, 2024 09:19
@ayush-shah
Copy link
Member Author

Screenshot 2024-10-07 at 2 41 42 PM Screenshot 2024-10-07 at 2 41 50 PM Screenshot 2024-10-07 at 3 01 33 PM

Tested on multiple dashboard connection settings to test out the changes

Copy link

sonarqubecloud bot commented Oct 7, 2024

Copy link

sonarqubecloud bot commented Oct 7, 2024

@chirag-madlani
Copy link
Collaborator

@ayush-shah py-tests are failing can you check?

@ayush-shah
Copy link
Member Author

@ayush-shah py-tests are failing can you check?

Failing Pytests are not related to the above PR, looks intermittent ( Lost connection to MySQL server during ), and some are already fixed in main.

@chirag-madlani
Copy link
Collaborator

@ayush-shah feel free to merge it 🚀

@ayush-shah ayush-shah merged commit 221327a into main Oct 8, 2024
25 of 27 checks passed
@ayush-shah ayush-shah deleted the refactor/service-connection-details branch October 8, 2024 05:59
harshach pushed a commit that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants