Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-1727: Pluralize owner label everywhere #18117

Merged
merged 9 commits into from
Oct 10, 2024
Merged

GEN-1727: Pluralize owner label everywhere #18117

merged 9 commits into from
Oct 10, 2024

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Oct 4, 2024

As we now have support for multiple owners, we should pluralize the owner label everywhere on the UI. This PR takes care of the same.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Oct 4, 2024
Copy link

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.18% (37779/58867) 40.94% (15071/36812) 42.95% (4551/10595)

Copy link

sonarqubecloud bot commented Oct 9, 2024

@chirag-madlani chirag-madlani merged commit d21ee58 into main Oct 10, 2024
17 checks passed
@chirag-madlani chirag-madlani deleted the GEN-1727 branch October 10, 2024 06:51
harshach pushed a commit that referenced this pull request Oct 19, 2024
* GEN-1727: Pluralize owner label everywhere

* fix: unit tests

* fix: playwright test

* adress comments

* fix playwright test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants