fix(ui): MSAL popup auth issue #18125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
safe to test
Jest test CoverageUI tests summary
|
|
chirag-madlani
requested review from
ShaileshParmar11,
karanh37 and
Sachin-chaurasiya
as code owners
Sachin-chaurasiya
approved these changes
Oct 5, 2024
| }, [instance]); | ||
|
|
||
| // Show loader until the interaction is completed | ||
| if (inProgress !== InteractionStatus.None) { |
There was a problem hiding this comment.
@chirag-madlani , why we are checking for none here?
There was a problem hiding this comment.
If azure is not processing anything related to auth then we can render the app, else loader will be shown
chirag-madlani
added a commit
that referenced
this pull request
Oct 5, 2024
(cherry picked from commit e44c8d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes: GEN-1557
brave
Screen.Recording.2024-10-05.at.11.39.04.AM.mov
Safari
Screen.Recording.2024-10-05.at.11.43.07.AM.mov
Chrome
Screen.Recording.2024-10-05.at.11.46.15.AM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>