Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: supported search filter and only all show in case of all node value selected #18136

Merged
merged 3 commits into from
Oct 7, 2024
Merged

MINOR: supported search filter and only all show in case of all node value selected #18136

merged 3 commits into from
Oct 7, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Oct 7, 2024 •
edited by chirag-madlani
Loading

Describe your changes:

  • Searching any index of an entity, will filter down the list.
  • When all is selected, should only show all in the select and not all the list

Issue :
image
image

Resolved :

image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Oct 7, 2024
@Ashish8689 Ashish8689 self-assigned this Oct 7, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.17% (37749/58822) 40.96% (15060/36771) 42.97% (4548/10584)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit aa7b95a into main Oct 7, 2024
16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the search-index-configuraion-form branch October 7, 2024 11:40
Ashish8689 added a commit that referenced this pull request Oct 9, 2024
@Ashish8689
MINOR: supported search filter and only all show in case of all node …
c3bee58 
…value selected (#18136)

* supported search filter and only all show in case of all node value selected

* updated the playwright test as per the all selector

* fix playwright and unit test

(cherry picked from commit aa7b95a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11