Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): move persona as top level settings #18171

Merged
merged 7 commits into from
Oct 9, 2024
Merged

chore(ui): move persona as top level settings #18171

merged 7 commits into from
Oct 9, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Oct 8, 2024 •
edited
Loading

Describe your changes:

Fixes: GEN-1780

  • Move Persona out of Members category of settings
  • Move Customise Landing Page under Persona Details page --> "Customise UI"
Screen.Recording.2024-10-08.at.11.12.21.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Oct 8, 2024
@CastleAndCountry
Copy link

Hi can I check if persona is supposed to be persisted on application restarts/page refreshes/clicking on the openmetadata logo to navigate to the landing page? On my end when I do any of the aforementioned, the persona that was selected will be set back to default.

@chirag-madlani
Copy link
Collaborator Author

Hi can I check if persona is supposed to be persisted on application restarts/page refreshes/clicking on the openmetadata logo to navigate to the landing page? On my end when I do any of the aforementioned, the persona that was selected will be set back to default.

@CastleAndCountry Can you reach out to our slack support?
Short answer to your question is you need to set defaultPersona from user profile page to have it persisted across the application.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.18% (37786/58875) 40.95% (15077/36822) 42.95% (4551/10596)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit 737c076 into main Oct 9, 2024
17 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the chore-persona branch October 9, 2024 08:55
harshach pushed a commit that referenced this pull request Oct 19, 2024
@chirag-madlani @harshach
chore(ui): move persona as top level settings (#18171)
f5989d5 
* chore(ui): pull persona as top level settings

* fix tests

* update breadcrumbs

* add missing type

* fix ui tests

* fix settings router tests
chirag-madlani added a commit that referenced this pull request Nov 19, 2024
@chirag-madlani
Revert "chore(ui): move persona as top level settings (#18171)"
706d1cc 
This reverts commit 737c076.
chirag-madlani added a commit that referenced this pull request Nov 19, 2024
@chirag-madlani
Revert persona (#18681)
431b30e 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
chirag-madlani added a commit that referenced this pull request Nov 28, 2024
@chirag-madlani
Revert persona (#18681)
9c0435b 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
chirag-madlani added a commit that referenced this pull request Nov 28, 2024
@chirag-madlani
Revert persona (#18681)
29e04d1 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
tutte pushed a commit that referenced this pull request Dec 2, 2024
@chirag-madlani @tutte
Revert persona (#18681)
08d4ff7 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
ulixius9 pushed a commit that referenced this pull request Dec 4, 2024
@chirag-madlani @ulixius9
Revert persona (#18681)
043688e 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
mohityadav766 pushed a commit that referenced this pull request Dec 4, 2024
@chirag-madlani @mohityadav766
Revert persona (#18681)
610c4ad 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
chirag-madlani added a commit that referenced this pull request Dec 4, 2024
@chirag-madlani
Revert persona (#18681)
b191783 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
ulixius9 pushed a commit that referenced this pull request Dec 5, 2024
@chirag-madlani @ulixius9
Revert persona (#18681)
ad1bcf6 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
chirag-madlani added a commit that referenced this pull request Dec 7, 2024
@chirag-madlani
Revert persona (#18681)
5d2c4c9 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
chirag-madlani added a commit that referenced this pull request Dec 9, 2024
@chirag-madlani
Revert persona (#18681)
b707563 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
ulixius9 pushed a commit that referenced this pull request Dec 9, 2024
@chirag-madlani @ulixius9
Revert persona (#18681)
7321a38 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
ulixius9 pushed a commit that referenced this pull request Dec 9, 2024
@chirag-madlani @ulixius9
Revert persona (#18681)
a79582d 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
ulixius9 pushed a commit that referenced this pull request Dec 10, 2024
@chirag-madlani @ulixius9
Revert persona (#18681)
15e519e 
* Revert "feat: persona based customisation for glossary and glossary term pages (#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirag-madlani @CastleAndCountry @ShaileshParmar11