Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Update DB2 dependencies to fix issue about not having ibm-db installed #18192

Merged
merged 2 commits into from
Oct 9, 2024
Merged

MINOR: Update DB2 dependencies to fix issue about not having ibm-db installed #18192

merged 2 commits into from
Oct 9, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Oct 9, 2024

Seems on our images sometimes ibm-db does not get installed. We're explicitely adding it as a dependency to prevent this issue.

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@IceS2 IceS2 requested a review from a team as a code owner October 9, 2024 14:01
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 9, 2024
SumanMaharana
SumanMaharana previously approved these changes Oct 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IceS2 IceS2 enabled auto-merge (squash) October 9, 2024 16:34
@IceS2 IceS2 merged commit 02d9494 into main Oct 9, 2024
16 checks passed
@IceS2 IceS2 deleted the update-db2-dependencies branch October 9, 2024 16:39
IceS2 added a commit that referenced this pull request Oct 10, 2024
@IceS2
MINOR: Update DB2 dependencies to fix issue about not having ibm-db i…
8c5d9ab 
…nstalled (#18192)

* Update DB2 dependencies to fix issue about not having ibm-db installed

* Fix checkstyle
harshach pushed a commit that referenced this pull request Oct 19, 2024
@IceS2 @harshach
MINOR: Update DB2 dependencies to fix issue about not having ibm-db i…
f4a6eee 
…nstalled (#18192)

* Update DB2 dependencies to fix issue about not having ibm-db installed

* Fix checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@SumanMaharana SumanMaharana SumanMaharana left review comments

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceS2 @pmbrull @SumanMaharana