Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): pagination with search on service page #18211

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes: Pagination not working when adding search in Service page

I worked on ... because ...

Screen.Recording.2024-10-10.at.3.05.26.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.18% (37788/58882) 40.94% (15078/36830) 42.95% (4551/10597)

Copy link

@Sachin-chaurasiya Sachin-chaurasiya merged commit 6b830f9 into main Oct 10, 2024
16 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the fix-pagination-services branch October 10, 2024 12:40
chirag-madlani added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants