-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed dbt Manifest and Run results parsing #18234
Fixed dbt Manifest and Run results parsing #18234
Conversation
for node, value in manifest_dict.get( # pylint: disable=unused-variable | ||
field | ||
).items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SumanMaharana here we should probably check manifest_dict.get(...
returns a dict and is not Null -- we can also update the method signature def remove_manifest_non_required_keys(self, manifest_dict: dict):
if we are expecting indeed a Dict[str, dict]
.
Otherwise we'll get
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'str' object has no attribute 'items'
or
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'NoneType' object has no attribute 'items'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TeddyCr manifest_dict.get(...
will always return a dict as its defined that way in dbt.
ingestion/src/metadata/ingestion/source/database/dbt/dbt_service.py
Outdated
Show resolved
Hide resolved
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Describe your changes:
Fixed dbt Manifest and Run results parsing
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>