Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: use global state for applications data #18250

Merged
merged 11 commits into from
Oct 21, 2024

Conversation

Kenil27
Copy link
Contributor

@Kenil27 Kenil27 commented Oct 14, 2024

Describe your changes:

Call applications API and set it in application state at root level

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

MetaPilot - Limits

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.15% (37894/59073) 40.89% (15123/36982) 42.93% (4559/10619)

@Kenil27 Kenil27 changed the title add check for MetaPilot - Limits UI: alternative for global state management for app wide data Oct 15, 2024
Copy link

@chirag-madlani chirag-madlani merged commit 2b21d11 into open-metadata:main Oct 21, 2024
14 of 16 checks passed
aniketkatkar97 pushed a commit that referenced this pull request Oct 28, 2024
* add check for MetaPilot - Limits

* code refactor

* move applications call from store to component

* fix:set value of applications from provider inside store

* update store inside provider

* fix failing tests
harshach pushed a commit that referenced this pull request Nov 3, 2024
* add check for MetaPilot - Limits

* code refactor

* move applications call from store to component

* fix:set value of applications from provider inside store

* update store inside provider

* fix failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants