GEN-927 - Add bot default roles #18256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmbrull
commented
Oct 14, 2024
| @@ -1488,8 +1495,9 @@ && userHasRelationshipWithAnyBot(original, bot)) { | |||
| original.getAuthenticationMechanism()); | |||
| user.setRoles(original.getRoles()); | |||
| } | |||
| // TODO remove this | |||
| // TODO remove this -> Still valid TODO? | |||
There was a problem hiding this comment.
@harshach not sure what was the context on this TODO. Is it still valid?
pmbrull
commented
Oct 14, 2024
| authMechanism = original.getAuthenticationMechanism(); | ||
| } | ||
| } | ||
| case SSO -> { |
There was a problem hiding this comment.
since we now only support the UI to create JWT bots, took the chance to remove this case
github-actions
bot
added
Ingestion
safe to test
|
harshach
approved these changes
Oct 21, 2024
harshach
pushed a commit
that referenced
this pull request
Nov 3, 2024
* GEN-927 - Add bot default roles * GEN-927 - Add bot default roles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes GEN-927
DefaultBotRolethat is added to any bot created. It contains theDefaultBotPolicyandDataConsumerPolicy. Without it, newly created bots did not have any kind of access to the data on a default installation of OM.DomainOnlyAccessRoleso that unless admins change it, that bot can only access its own dataType of change:
Checklist:
Fixes <issue-number>: <short explanation>