Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx #17933: Superset fix chart query for mysql con. #18272

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

harshsoni2024
Copy link
Contributor

Describe your changes:

Fixes #17933

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

@IceS2 IceS2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe we could have the logic in one place, doing something like:

def getSupersetQuery(String query, Connection connection):
  if isinstance(connection, MysqlConnection):
    return query.replace('"', "`")
  return query

Copy link

@harshsoni2024
Copy link
Contributor Author

Looks good, but maybe we could have the logic in one place, doing something like:

def getSupersetQuery(String query, Connection connection):
  if isinstance(connection, MysqlConnection):
    return query.replace('"', "`")
  return query

I'll do this in next changes sure. Need to cherry-pick this branch today 😅

@harshsoni2024 harshsoni2024 merged commit eb49d7a into open-metadata:main Oct 15, 2024
22 of 37 checks passed
harshsoni2024 added a commit that referenced this pull request Oct 15, 2024
harshach pushed a commit that referenced this pull request Oct 17, 2024
harshach pushed a commit that referenced this pull request Oct 19, 2024
@harshsoni2024 harshsoni2024 deleted the issue-17933 branch December 19, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superset MySQL API Connection Fails on getCharts Due to Incorrect Backend Query in OpenMetadata
3 participants