-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx #17933: Superset fix chart query for mysql con. #18272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but maybe we could have the logic in one place, doing something like:
def getSupersetQuery(String query, Connection connection):
if isinstance(connection, MysqlConnection):
return query.replace('"', "`")
return query
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
I'll do this in next changes sure. Need to cherry-pick this branch today 😅 |
Describe your changes:
Fixes #17933
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>