-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GEN-1856 encode and escape search value for the tag search #18285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-madlani
requested review from
ShaileshParmar11,
karanh37 and
Sachin-chaurasiya
as code owners
October 16, 2024 05:12
github-actions
bot
added
safe to test
Add this label to run secure Github workflows on PRs
UI
UI specific issues
labels
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we update name in E2E so we can check if its working as expected
ShaileshParmar11
previously approved these changes
Oct 16, 2024
Quality Gate passed for 'open-metadata-ui'Issues Measures |
ShaileshParmar11
approved these changes
Oct 16, 2024
chirag-madlani
added a commit
that referenced
this pull request
Oct 16, 2024
* fix: GEN-1856 encode and escape search value for the tag * fix test * add missing import (cherry picked from commit 3b182c9)
harshach
pushed a commit
that referenced
this pull request
Oct 17, 2024
* fix: GEN-1856 encode and escape search value for the tag * fix test * add missing import
harshach
pushed a commit
that referenced
this pull request
Oct 19, 2024
* fix: GEN-1856 encode and escape search value for the tag * fix test * add missing import
harshach
pushed a commit
that referenced
this pull request
Nov 3, 2024
* fix: GEN-1856 encode and escape search value for the tag * fix test * add missing import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes: GEN-1856
Screen.Recording.2024-10-16.at.10.41.43.AM.mov
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>