Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GEN-1856 encode and escape search value for the tag search #18285

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes: GEN-1856

Screen.Recording.2024-10-16.at.10.41.43.AM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update name in E2E so we can check if its working as expected

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.15% (37837/58980) 40.89% (15078/36876) 42.94% (4553/10603)

Copy link

@chirag-madlani chirag-madlani merged commit 3b182c9 into main Oct 16, 2024
16 checks passed
@chirag-madlani chirag-madlani deleted the fix-GEN-1856 branch October 16, 2024 12:45
chirag-madlani added a commit that referenced this pull request Oct 16, 2024
* fix: GEN-1856 encode and escape search value for the tag

* fix test

* add missing import

(cherry picked from commit 3b182c9)
harshach pushed a commit that referenced this pull request Oct 17, 2024
* fix: GEN-1856 encode and escape search value for the tag

* fix test

* add missing import
harshach pushed a commit that referenced this pull request Oct 19, 2024
* fix: GEN-1856 encode and escape search value for the tag

* fix test

* add missing import
harshach pushed a commit that referenced this pull request Nov 3, 2024
* fix: GEN-1856 encode and escape search value for the tag

* fix test

* add missing import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants