Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: skip the permission spec #18336

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Minor: skip the permission spec #18336

merged 1 commit into from
Oct 21, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Oct 21, 2024 •
edited
Loading

Describe your changes:

Skip the permission spec, as there are some changes from the backend that are causing the failure, we need to modify the permission spec based on the changes.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.15% (37894/59073) 40.89% (15123/36982) 42.93% (4559/10619)

@chirag-madlani chirag-madlani merged commit 890b500 into main Oct 21, 2024
14 of 16 checks passed
@chirag-madlani chirag-madlani deleted the skip-permission-spec branch October 21, 2024 05:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

harshach pushed a commit that referenced this pull request Nov 3, 2024
@ShaileshParmar11 @harshach
skip the permission spec (#18336)
5537724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
hacktoberfest safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani