Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - Only timeout on main threads #18341

Merged
merged 1 commit into from
Oct 21, 2024
Merged

MINOR - Only timeout on main threads #18341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ingestion/src/metadata/utils/timeout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import os
import platform
import signal
import threading
from typing import Callable

from metadata.utils.constants import TEN_MIN
Expand Down Expand Up @@ -47,7 +48,11 @@ def timeout(seconds: int = TEN_MIN) -> Callable:
def decorator(fn):
@functools.wraps(fn)
def inner(*args, **kwargs):
if platform.system() != "Windows": # SIGALRM not supported on Windows
# SIGALRM is not supported on Windows or sub-threads
if (
platform.system() != "Windows"
and threading.current_thread() == threading.main_thread()
):
signal.signal(signal.SIGALRM, _handle_timeout)
signal.alarm(seconds)
try:
Expand Down
Loading