Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supported total unique user count in Team page #18361

Merged
merged 5 commits into from
Oct 22, 2024
Merged

supported total unique user count in Team page #18361

merged 5 commits into from
Oct 22, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Oct 22, 2024 •
edited
Loading

Describe your changes:

Fixes

  • I worked on showing total unique user count in the Teams.
  • Remove the user field from Business, Division and Depaertment team as it was ir-relevant there
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Oct 22, 2024
@Ashish8689 Ashish8689 self-assigned this Oct 22, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.15% (37894/59071) 40.9% (15123/36980) 42.93% (4559/10619)

@Ashish8689 Ashish8689 marked this pull request as ready for review October 22, 2024 10:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit 4c4587c into main Oct 22, 2024
15 of 17 checks passed
@Ashish8689 Ashish8689 deleted the team-user-count-display branch October 22, 2024 20:50
Ashish8689 added a commit that referenced this pull request Oct 22, 2024
@Ashish8689
supported total unique user count in Team page (#18361)
ed937b8 
* supported total distinct user count in Team page

* minor improvement

* fix unit test

* added helpertext tooltip and change the label

* minor cosmetic update

(cherry picked from commit 4c4587c)
harshach pushed a commit that referenced this pull request Nov 3, 2024
@Ashish8689 @harshach
supported total unique user count in Team page (#18361)
e847172 
* supported total distinct user count in Team page

* minor improvement

* fix unit test

* added helpertext tooltip and change the label

* minor cosmetic update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @chirag-madlani