Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query builder improvements #18377

Merged
merged 1 commit into from
Oct 23, 2024
Merged

query builder improvements #18377

merged 1 commit into from
Oct 23, 2024

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Oct 23, 2024 •
edited
Loading

Describe your changes:

Fixes

Loads entity type value from schema value and updates the widget options.
Changed the width of configuration on AppInstall page.

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.13% (37926/59135) 40.73% (15145/37182) 42.93% (4564/10632)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@karanh37 karanh37 merged commit ef0b03d into main Oct 23, 2024
14 of 16 checks passed
@karanh37 karanh37 deleted the query-builder-improvements branch October 23, 2024 12:35
pmbrull pushed a commit that referenced this pull request Oct 25, 2024
@karanh37 @pmbrull
query builder improvements (#18377)
0f047c3
harshach pushed a commit that referenced this pull request Nov 3, 2024
@karanh37 @harshach
query builder improvements (#18377)
537d913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanh37 @chirag-madlani @pmbrull