Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN 1931 - Fix entity link accepted chars #18391

Merged
merged 16 commits into from
Oct 29, 2024
Merged

GEN 1931 - Fix entity link accepted chars #18391

merged 16 commits into from
Oct 29, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Oct 24, 2024 •
edited by aniketkatkar97
Loading

Describe your changes:

  • Fix accepted entityLink characters

    • accept any characters but :: < > and |

  • Fix the API call throwing error in case a special character is in the test suite FQN

Before:

Screen.Recording.2024-10-28.at.9.03.56.PM.mov

After:

Screen.Recording.2024-10-28.at.8.55.36.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner October 24, 2024 09:23
@notion-workspace Notion Workspace
Copy link

[ ] throws error on the entityLink

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 24, 2024
pmbrull
pmbrull previously approved these changes Oct 25, 2024
View reviewed changes
@TeddyCr TeddyCr requested a review from pmbrull October 28, 2024 12:23
pmbrull
pmbrull previously approved these changes Oct 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

harshach
harshach previously approved these changes Oct 28, 2024
View reviewed changes
@TeddyCr TeddyCr dismissed stale reviews from ShaileshParmar11 and harshach via 4249424 October 29, 2024 06:20
pmbrull
pmbrull previously approved these changes Oct 29, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 4f8bf05 into open-metadata:main Oct 29, 2024
24 of 27 checks passed
aniketkatkar97 added a commit that referenced this pull request Oct 29, 2024
@aniketkatkar97
GEN 1931 - Fix entity link accepted chars (#18391)
46cf15c
harshach pushed a commit that referenced this pull request Nov 3, 2024
@TeddyCr @aniketkatkar97 @harshach
GEN 1931 - Fix entity link accepted chars (#18391)
9e755bd 
* fix: entity link accepted characters

* fix: match all characters but `<>|::`

* fix: remove unnecessary negative lookbehind

* fix the test case search not working on add ingestion page in case of special characters in FQN

* style: ran java linting

* fix: failing testst

* style: ran java linting

---------

Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@chirag-madlani chirag-madlani chirag-madlani left review comments

@harshach harshach harshach left review comments

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TeddyCr @harshach @chirag-madlani @pmbrull @ShaileshParmar11 @aniketkatkar97