Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - Renaming MetaPilot to CollateAI #18393

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Oct 24, 2024

Describe your changes:

  1. Renaming MetaPilot to Collate AI
  2. Moving App limits migrations from 1.6.0 to 1.5.9

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

Copy link

@pmbrull pmbrull marked this pull request as ready for review October 28, 2024 07:31
@pmbrull pmbrull requested a review from a team as a code owner October 28, 2024 07:31
@@ -0,0 +1,5 @@
-- Extend app extension for limits
ALTER TABLE apps_extension_time_series ADD COLUMN extension VARCHAR(255);
UPDATE apps_extension_time_series SET extension = 'status' WHERE extension IS NULL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what the extension = 'status' represents?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we only used the apps_extension_time_series to store status information about the Internal Apps (e.g., Data Insights or Reindex).

Now however I re-purposed the table to also store:

  • limits info about app usage
  • custom state of the app that needs to be tracked.

The status just helps us index the data and fetch whatever is needed in each scenario

"description": "Application type.",
"type": "string",
"enum": ["MetaPilot"],
"default": "MetaPilot"
"enum": ["CollateAI"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to replace this in the code anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code lives in Collate, so updating it there. We still need to put collate-only apps here since we don't know how to extend the oneOf dynamically

@pmbrull pmbrull merged commit 7d01373 into open-metadata:main Oct 28, 2024
23 checks passed
pmbrull added a commit that referenced this pull request Oct 28, 2024
* MINOR - Renaming MetaPilot to CollateAI

* MINOR - Renaming MetaPilot to CollateAI

* MINOR - Renaming MetaPilot to CollateAI

* MINOR - Renaming MetaPilot to CollateAI

* fix

* moving limits migrations for 1.5.9
harshach pushed a commit that referenced this pull request Nov 3, 2024
* MINOR - Renaming MetaPilot to CollateAI

* MINOR - Renaming MetaPilot to CollateAI

* MINOR - Renaming MetaPilot to CollateAI

* MINOR - Renaming MetaPilot to CollateAI

* fix

* moving limits migrations for 1.5.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants