fix: application support email link with mailto: URI schema
#18416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sachin-chaurasiya
requested review from
ShaileshParmar11,
karanh37 and
chirag-madlani
as code owners
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
changed the title
mailto: URI schemamailto: URI schema
github-actions
bot
added
safe to test
Jest test CoverageUI tests summary
|
|
chirag-madlani
approved these changes
Oct 28, 2024
chirag-madlani
pushed a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 09e6671)
harshach
pushed a commit
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: We were directly using the email address as the
hrefvalue for the anchor element for application support. This is causing an issue where the linkhttps://domain.com/path/apps/emailidis created incorrectly. Instead of opening the email client when clicking onGet App Support, it opens the application path and treats the email address as a fully qualified name of the application.Screen.Recording.2024-10-27.at.9.36.09.PM.mov
Fix: Added a
mailto:URI scheme so that theGet App Supportlink opens the user's default email client with the provided support email address.Screen.Recording.2024-10-27.at.9.38.35.PM.mov