Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix create admin page data and fields #18458

Merged
merged 4 commits into from
Nov 5, 2024
Merged

MINOR: fix create admin page data and fields #18458

merged 4 commits into from
Nov 5, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Oct 29, 2024 •
edited by ShaileshParmar11
Loading

Describe your changes:

Fixes

  • I worked on fixing Create Admin page data and fields.

  • Admin flag is on by default in case of Create Admin User

  • Team and Role field is removed in case of Create Admin Page

  • Breadcrumb is set as per Create Admin page

Screen.Recording.2024-10-29.at.6.33.34.PM.mov

In case of normal user
image

In case of admin user
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Oct 29, 2024
@Ashish8689 Ashish8689 self-assigned this Oct 29, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.4% (38548/59859) 41.17% (15478/37591) 43.1% (4615/10708)

@Ashish8689 Ashish8689 marked this pull request as draft October 30, 2024 07:04
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review November 5, 2024 10:01
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit 76a257f into main Nov 5, 2024
15 of 16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the create-admin-page-fix branch November 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @ShaileshParmar11