Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: use enum.Enum instead of sqlalchemy enum for Dialects #18464

Merged
merged 3 commits into from
Nov 7, 2024
Merged

MINOR: use enum.Enum instead of sqlalchemy enum for Dialects #18464

merged 3 commits into from
Nov 7, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Oct 29, 2024 •
edited
Loading

Describe your changes:

Use python enums instead of sqlalchemy enums which have more functionality than (like inverse access and iteration) sql alchemy enums that are meant to be used in the context of the sql alchemy ORM or query builder.

Implemented an adapter that keeps the previous functionality to not break existing code.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner October 29, 2024 16:09
@sushi30 sushi30 changed the title fix: use enum.Enum instead of sqlalchemy enum MINOR: use enum.Enum instead of sqlalchemy enum Oct 29, 2024
@sushi30 sushi30 enabled auto-merge (squash) October 29, 2024 16:10
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 29, 2024
@sushi30 sushi30 changed the title MINOR: use enum.Enum instead of sqlalchemy enum MINOR: use enum.Enum instead of sqlalchemy enum for Dialects Oct 30, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sushi30 sushi30 merged commit 729a06b into main Nov 7, 2024
16 checks passed
@sushi30 sushi30 deleted the dialects-enum branch November 7, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceS2 IceS2 IceS2 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushi30 @IceS2