Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: revert e2e python job link #18473

Merged
merged 2 commits into from
Oct 31, 2024
Merged

MINOR: revert e2e python job link #18473

merged 2 commits into from
Oct 31, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Oct 30, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30
ci(py-cli-e2e): remove job id from link
fc96e15 
remove job id from link. it doesn't work for matrix
@sushi30
fix the condition for env.DEBUG
21e6945
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 30, 2024
@sushi30 sushi30 enabled auto-merge (squash) October 30, 2024 11:01
@sushi30 sushi30 changed the title MINOR: fix e2e python job MINOR: fix e2e python job link Oct 31, 2024
@sushi30 sushi30 changed the title MINOR: fix e2e python job link MINOR: revert e2e python job link Oct 31, 2024
@sushi30 sushi30 merged commit 2539ffa into main Oct 31, 2024
11 checks passed
@sushi30 sushi30 deleted the e2e-job-link branch October 31, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tutte tutte tutte approved these changes

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10 akash-jain-10 is a code owner

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushi30 @tutte