Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Debuggability Migration #18485

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix Debuggability Migration #18485

merged 1 commit into from
Oct 31, 2024

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Oct 31, 2024 •
edited
Loading

Describe your changes:

Add the source column Without the NOT NULL constraint on consumers_dlq, populate it later with Publisher in postDataMigration

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs migration labels Oct 31, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Oct 31, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team October 31, 2024 06:29
@Siddhanttimeline Siddhanttimeline enabled auto-merge (squash) October 31, 2024 06:43
@mohityadav766 mohityadav766 merged commit 4f5bfa8 into main Oct 31, 2024
27 of 28 checks passed
@mohityadav766 mohityadav766 deleted the fix-migration-debuggability branch October 31, 2024 08:40
@Siddhanttimeline
Copy link
Contributor Author

Resolves migration issues related to #18199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend migration safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siddhanttimeline @mohityadav766