Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support for column customization for Glossary term table #18584

Conversation

shrushti2000
Copy link
Contributor

@shrushti2000 shrushti2000 commented Nov 11, 2024

This PR introduces enhancements to the Glossary Term table, adding support for column customization and improving the status filtering mechanism. The following features have been implemented:

  1. Column Selection via Dropdown: Users can choose which columns to display in the Glossary Term table using a dropdown menu, allowing for a more customized table view.

  2. Rearrangement of Columns: Users can rearrange the columns in the table by dragging and dropping them to their desired positions within the column selection dropdown.

  3. Addition of Two New Columns: The Glossary Term table now includes two new columns: Synonyms and Reviewers, providing additional term-related information.

  4. Fixed "Name" Column: The "Name" column is now fixed and cannot be hidden, ensuring it remains visible at all times while users customize the other columns.

  5. Table-Level Status Filtering with Dropdown: The column-level filtering for status has been removed and replaced with a table-level filter. Users can now filter by status using a dropdown selection at the top of the table, making it easier to manage status-based filtering.

Feature Demo: Column Customization in Glossary

Screen.Recording.2024-11-12.at.12.54.00.PM.1.mov

Feature Demo: Table-Level Status Filtering

Screen.Recording.2024-11-12.at.5.05.41.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.56% (39261/61773) 40.14% (15548/38731) 42.24% (4665/11044)

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

@Sachin-chaurasiya Sachin-chaurasiya merged commit 626464f into open-metadata:main Nov 14, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants