Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-970] feat(data-quality): support multiple runtime parameter types #18588

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Nov 11, 2024

  • changed the runtime parameters setter factory to return sets
  • add the runtime parameters based on the name of the runtime of the runtime parameter

NOTE requires changes on collate side

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

- changed the runtime parameters setter factory to return sets
- add the runtime parameters based on the name of the runtime of the runtime parameter

**NOTE** requires changes on collate side
@sushi30 sushi30 requested a review from a team as a code owner November 11, 2024 15:56
Copy link

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename it to validator_builder_interface and ValidatorBuilderInterface. Not sure why I named it like that, but we use that convention everywhere else.

Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a small comment. Would we need to change the way we call self.get_runtime_parameters anywhere else as well?

@sushi30
Copy link
Contributor Author

sushi30 commented Nov 21, 2024

@TeddyCr I didn't see any other change that is required. LMK if you see something.

@sushi30 sushi30 merged commit 0169aad into main Nov 21, 2024
16 checks passed
@sushi30 sushi30 deleted the multiple-runtime-parameter-setters branch November 21, 2024 07:07
harshach pushed a commit that referenced this pull request Nov 24, 2024
#18588)

* feat(data-quality): support multiple runtime parameter types

- changed the runtime parameters setter factory to return sets
- add the runtime parameters based on the name of the runtime of the runtime parameter

**NOTE** requires changes on collate side

* empty set for default case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants