-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-970] feat(data-quality): support multiple runtime parameter types #18588
Conversation
- changed the runtime parameters setter factory to return sets - add the runtime parameters based on the name of the runtime of the runtime parameter **NOTE** requires changes on collate side
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename it to validator_builder_interface
and ValidatorBuilderInterface
. Not sure why I named it like that, but we use that convention everywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left a small comment. Would we need to change the way we call self.get_runtime_parameters
anywhere else as well?
@TeddyCr I didn't see any other change that is required. LMK if you see something. |
#18588) * feat(data-quality): support multiple runtime parameter types - changed the runtime parameters setter factory to return sets - add the runtime parameters based on the name of the runtime of the runtime parameter **NOTE** requires changes on collate side * empty set for default case
NOTE requires changes on collate side
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>