Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thai languages #18595

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Add Thai languages #18595

merged 4 commits into from
Nov 14, 2024

Conversation

codeasai
Copy link
Contributor

@codeasai codeasai commented Nov 12, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@jgrocha
Copy link
Contributor

jgrocha commented Nov 12, 2024

Hi @codeasai ,

I did a similar PR, to add another language.

Maybe you should also update openmetadata-ui/src/main/resources/ui/src/utils/i18next/i18nextUtil.ts.
The logic for knowing the browser's accepted languages is in that file. If the browser's first language is th-th, you must tell it to use your th-th.json translations.

This is just a comment from another user. OpenMetadata developers may have a different opinion.

@codeasai
Copy link
Contributor Author

Hi, @jgrocha

Thank you very much for your advice. I will try to study the subject you mentioned.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.56% (39269/61778) 40.15% (15545/38718) 42.24% (4665/11044)

Copy link

@Sachin-chaurasiya Sachin-chaurasiya merged commit a302681 into open-metadata:main Nov 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants