Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 16805: pagination dropdown issue #18611

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Fix 16805: pagination dropdown issue #18611

merged 4 commits into from
Nov 13, 2024

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Nov 12, 2024 •
edited by Sachin-chaurasiya
Loading

Fixes #16805

I worked on pagination dropdown for the pages, DatabaseSchemaPage, APICollectionPage, ServiceDetailsPage, etc.

Screenshot 2024-11-12 at 7 53 13 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 changed the title Fix 16805: pagination dropdown (#18433) Fix 16805: pagination dropdown issue Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 marked this pull request as ready for review November 13, 2024 05:56
@karanh37 karanh37 added the safe to test Add this label to run secure Github workflows on PRs label Nov 13, 2024
@ShaileshParmar11 ShaileshParmar11 added the UI UI specific issues label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.72% (39104/61368) 40.34% (15530/38496) 42.35% (4645/10968)

Sachin-chaurasiya
Sachin-chaurasiya reviewed Nov 13, 2024
View reviewed changes
openmetadata-ui/src/main/resources/ui/src/pages/APICollectionPage/APICollectionPage.tsx
Comment on lines +104 to +106
const pagingInfo = usePaging(PAGE_SIZE);

const { paging, pageSize, handlePagingChange } = pagingInfo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const pagingInfo = usePaging(PAGE_SIZE);
const { paging, pageSize, handlePagingChange } = pagingInfo;
const { paging, pageSize, handlePagingChange } = usePaging(PAGE_SIZE);

Copy link
Contributor Author

@pranita09 pranita09 Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pagingInfo has other properties like showPagination, handlePageChange, etc. and these properties are being used in other components where we pass pagingInfo as a prop.
On line 106, the destructured properties are being used in the component.

ShaileshParmar11
ShaileshParmar11 reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix playwright before merging

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ShaileshParmar11 ShaileshParmar11 merged commit 00357f6 into open-metadata:main Nov 13, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search Results Pagination Issue
4 participants
@pranita09 @Sachin-chaurasiya @ShaileshParmar11 @karanh37