Fix: update glossary terms table stylings and temporarily bypass failing drag-and-drop test #18653
Conversation
shrushti2000
requested review from
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Sachin-chaurasiya
added
the
safe to test
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Jest test CoverageUI tests summary
|
| .select-all-checkbox { | ||
| font-size: 14px; | ||
| color: @grey-4; | ||
| height: 33px; | ||
| padding-left: 28px; | ||
| display: flex; | ||
| align-items: center; | ||
| width: 100%; | ||
| margin-bottom: 4px; | ||
| .ant-checkbox-inner { | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
| .select-all-dropdown-text { | ||
| margin-left: 8px; | ||
| margin-top: 10px; | ||
| } | ||
| } | ||
|
|
||
| .custom-glossary-dropdown-action-btn { |
There was a problem hiding this comment.
would recommend to use less custom css and more use of AntD component props to achieve alignment and designs
There was a problem hiding this comment.
Done,have reduced the use of custom css wherever possible and replaced it with classnames
| .glossary-dropdown-actions-container { | ||
| padding-top: 5px; | ||
| } |
There was a problem hiding this comment.
Please do not use padding for aligenement fixes
There was a problem hiding this comment.
Done, have removed the use of padding as an alignment fix
| @@ -95,21 +95,19 @@ | |||
| font-size: 16px; | |||
| color: @grey-3; | |||
| width: 100%; | |||
|
|
|||
| margin-left: 15px; | |||
There was a problem hiding this comment.
Can we use our spacing variables instead?
You can refer to this: https://github.com/open-metadata/OpenMetadata/blob/b763091bf66bc44cc7d47dcd24e93a936aaec610/openmetadata-ui/src/main/resources/ui/src/styles/variables.less
There was a problem hiding this comment.
Done, have replaced this with spacing variable
| .ant-checkbox-wrapper { | ||
| height: 33px; | ||
| } |
There was a problem hiding this comment.
Any reason to have custom height here?
There was a problem hiding this comment.
A custom height of 33px was added to .ant-checkbox-wrapper to visually align the checkbox with adjacent elements, as the default height caused minor misalignment.
|
This PR introduces following fixes,
Glossary Terms Table Styling:
Fixes layout and styling issues for the terms table to improve readability and alignment.
Drag-and-Drop Test Update:
Temporarily disables a failing drag-and-drop test of Glossary Terms table for further investigation and debugging.
Screen.Recording.2024-11-15.at.11.36.00.AM.1.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>