Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#18677 - Added Lineage Field back to SearchLineage #18687

Merged
merged 4 commits into from
Nov 20, 2024
Merged

#18677 - Added Lineage Field back to SearchLineage #18687

merged 4 commits into from
Nov 20, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 19, 2024

Describe your changes:

Fixes

  • added lineage field back to search lineage
Screen.Recording.2024-11-19.at.9.20.15.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner November 19, 2024 09:34
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 19, 2024
pmbrull
pmbrull previously approved these changes Nov 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.57% (39788/62593) 40.19% (15796/39307) 42.33% (4723/11158)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TeddyCr TeddyCr merged commit 429e48a into open-metadata:main Nov 20, 2024
21 of 26 checks passed
TeddyCr added a commit that referenced this pull request Nov 20, 2024
@TeddyCr
#18677 - Added Lineage Field back to SearchLineage (#18687)
05c3758 
* fix: add lineage field back to searchLineage

* add lineage tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
(cherry picked from commit 429e48a)
TeddyCr added a commit that referenced this pull request Nov 20, 2024
@TeddyCr
#18677 - Added Lineage Field back to SearchLineage (#18687)
121e87c 
* fix: add lineage field back to searchLineage

* add lineage tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
(cherry picked from commit 429e48a)
harshach pushed a commit that referenced this pull request Nov 24, 2024
@TeddyCr @karanh37 @harshach
#18677 - Added Lineage Field back to SearchLineage (#18687)
4d9ac01 
* fix: add lineage field back to searchLineage

* add lineage tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyCr @pmbrull @karanh37