Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Custom Metric Updation in profiler #18708

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Docs: Custom Metric Updation in profiler #18708

merged 1 commit into from
Nov 20, 2024

Conversation

RounakDhillon
Copy link
Contributor

Describe your changes:

Fixes

I worked on Custom Metric Updation in profiler.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Prajwal214
Prajwal214 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Prajwal214 Prajwal214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Prajwal214 Prajwal214 added the safe to test Add this label to run secure Github workflows on PRs label Nov 20, 2024
@Prajwal214 Prajwal214 enabled auto-merge (squash) November 20, 2024 13:10
@Prajwal214 Prajwal214 merged commit 0e3e1f5 into open-metadata:main Nov 20, 2024
17 of 20 checks passed
harshach pushed a commit that referenced this pull request Nov 24, 2024
@RounakDhillon @harshach
Docs: Custom Metric Updation in profiler (#18708)
966df7f 
Co-authored-by: Rounak Dhillon <rounakdhillon@Rounaks-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajwal214 Prajwal214 Prajwal214 approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RounakDhillon @Prajwal214