minor: improve rule card actions dropdown #18717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
github-actions
bot
added
safe to test
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Jest test CoverageUI tests summary
|
|
Sachin-chaurasiya
requested review from
ShaileshParmar11,
karanh37 and
chirag-madlani
as code owners
ShaileshParmar11
approved these changes
Nov 21, 2024
chirag-madlani
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Removed the deprecated
overlayprop from the dropdown component and replaced it with themenuprop. Added an onClick option to handle item clicks and perform actions based on the selected item.Also fixed icon size and alignments.
Screen.Recording.2024-11-21.at.1.52.50.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>