Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: shown NoDataPlaceholder if no search result found in glossary #18718

Merged
merged 4 commits into from
Nov 21, 2024
Merged

MINOR: shown NoDataPlaceholder if no search result found in glossary #18718

merged 4 commits into from
Nov 21, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes

  • I worked on showing NoDataPlaceholder if no search result found in glossary

Issue :

Screen.Recording.2024-11-14.at.06.19.46.mov

Resolved :

Screen.Recording.2024-11-21.at.2.37.36.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 21, 2024
@Ashish8689 Ashish8689 self-assigned this Nov 21, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.58% (39841/62659) 40.16% (15817/39385) 42.33% (4725/11161)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit 253fc6b into main Nov 21, 2024
14 of 16 checks passed
@Ashish8689 Ashish8689 deleted the tree-select-list-no-data branch November 21, 2024 17:12
harshach pushed a commit that referenced this pull request Nov 24, 2024
@Ashish8689 @harshach
MINOR: shown NoDataPlaceholder if no search result found in glossary (#…
7b766b7 
…18718)

* shown NoDataPlaceholder if no search result found in glossary

* minor label change

* added loader, while search response pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11