Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify fqn to allow quotes with dots #18719

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: modify fqn to allow quotes with dots #18719

merged 3 commits into from
Nov 22, 2024

Conversation

ayush-shah
Copy link
Member

@ayush-shah ayush-shah commented Nov 21, 2024 •
edited
Loading

Describe your changes:

Fixes FQN issue

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 21, 2024
@ayush-shah ayush-shah marked this pull request as ready for review November 21, 2024 12:18
@ayush-shah ayush-shah requested a review from a team as a code owner November 21, 2024 12:18
chirag-madlani
chirag-madlani previously approved these changes Nov 21, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ayush-shah ayush-shah merged commit 17ffdf9 into main Nov 22, 2024
19 of 21 checks passed
@ayush-shah ayush-shah deleted the fix-fqn branch November 22, 2024 04:03
ayush-shah added a commit that referenced this pull request Nov 22, 2024
@ayush-shah
fix: modify fqn to allow quotes with dots (#18719)
19f02a1
harshach pushed a commit that referenced this pull request Nov 24, 2024
@ayush-shah @harshach
fix: modify fqn to allow quotes with dots (#18719)
b1d6b4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushi30 sushi30 sushi30 approved these changes

@chirag-madlani chirag-madlani chirag-madlani left review comments

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayush-shah @chirag-madlani @sushi30