TEST - Add autoClassification for e2e #18722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
|
IceS2
approved these changes
Nov 21, 2024
| # pylint: disable=invalid-name | ||
| def __init__(self, config: dict, config_args: dict) -> None: | ||
| super().__init__(config, config_args) | ||
| self.profilerSample = self.config_args.get("profilerSample", 100) |
There was a problem hiding this comment.
Do we want 100% profile sample for tests?
There was a problem hiding this comment.
keeping what we had in the profiler already. I believe tables should be small. If we want to change this, let's change it everywhere and double-check the resulting counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>