Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test case result reindex performance #18723

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 21, 2024

Describe your changes:

  • remove redundant test case results list db calls
  • only fetch test suite result summary if summary field is present
  • pass explicit field when denormalizing test case result relationship on indexation

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@TeddyCr TeddyCr requested a review from a team as a code owner November 21, 2024 10:43
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 21, 2024
@TeddyCr TeddyCr changed the title fix: test case reindex performance fix: test case result reindex performance Nov 21, 2024
Copy link

@TeddyCr TeddyCr merged commit dbd03c6 into open-metadata:main Nov 21, 2024
12 of 18 checks passed
TeddyCr added a commit that referenced this pull request Nov 21, 2024
harshach pushed a commit that referenced this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants