Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2109] feat(mongo): added ssl support #18731

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[GEN-2109] feat(mongo): added ssl support #18731

merged 2 commits into from
Nov 22, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Nov 21, 2024

Added SSL support for MongoDB using the SSL manager.

Demo

ssl configuration starts at 0:51

Screen.Recording.2024-11-21.at.16.37.23.mov

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Added SSL support for MongoDB using the SSL manager.

Attached a video demo.

- [Example repository for setting up mongodb with SSL](https://github.com/sushi30/mongodb-docker-ssl-example)
- [MongoDB TLS documentation](https://www.mongodb.com/docs/manual/tutorial/configure-ssl/)
@sushi30 sushi30 requested a review from a team as a code owner November 21, 2024 15:45
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 21, 2024
@sushi30 sushi30 changed the title MINOR: feat(mongo): added ssl support [GEN-2109] feat(mongo): added ssl support Nov 21, 2024
Copy link

MongoDB SSL

@harshach
Copy link
Collaborator

@sushi30 we need migrations for this right, since we are changing the connection config?

Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks

@sushi30
Copy link
Contributor Author

sushi30 commented Nov 22, 2024

@harshach since ssl is by not required and null default it's backward compatible no migrations are required. I tested it locally by creating the connection on main and spinning up the branch version. I was able to read the connection and add SSL configuration.

@sushi30 sushi30 enabled auto-merge (squash) November 22, 2024 14:05
Copy link

@harshach harshach disabled auto-merge November 22, 2024 16:54
@harshach harshach merged commit ee7d043 into main Nov 22, 2024
16 of 21 checks passed
@harshach harshach deleted the add-mongo-tls branch November 22, 2024 16:54
sushi30 added a commit that referenced this pull request Nov 22, 2024
* feat(mongo): added ssl support

Added SSL support for MongoDB using the SSL manager.

Attached a video demo.

- [Example repository for setting up mongodb with SSL](https://github.com/sushi30/mongodb-docker-ssl-example)
- [MongoDB TLS documentation](https://www.mongodb.com/docs/manual/tutorial/configure-ssl/)

* fixed test_doris.py

(cherry picked from commit ee7d043)
harshach pushed a commit that referenced this pull request Nov 24, 2024
* feat(mongo): added ssl support

Added SSL support for MongoDB using the SSL manager.

Attached a video demo.

- [Example repository for setting up mongodb with SSL](https://github.com/sushi30/mongodb-docker-ssl-example)
- [MongoDB TLS documentation](https://www.mongodb.com/docs/manual/tutorial/configure-ssl/)

* fixed test_doris.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants