Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mstr removed dependency issues #18732

Merged
merged 13 commits into from
Nov 22, 2024

Conversation

SumanMaharana
Copy link
Contributor

Describe your changes:

Fix: mstr removed dependency issues
mstrio-py had lot of dependencies which do not align with other OSS entity
removed that dependency by using the requests lib

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

pmbrull
pmbrull previously approved these changes Nov 22, 2024
Copy link

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions
11.1% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@SumanMaharana SumanMaharana merged commit b220bdb into open-metadata:main Nov 22, 2024
11 of 16 checks passed
@SumanMaharana SumanMaharana deleted the fix-mstr-api branch November 22, 2024 15:49
SumanMaharana added a commit that referenced this pull request Nov 22, 2024
* Fix: mstr removed dependency issues

* fix session still active error

* py_format

* fix tests

* Addressed Comments

* Addressed Comments

* addressed comments

* Addressed comments

* Add constants

* Fix pytests
harshach pushed a commit that referenced this pull request Nov 24, 2024
* Fix: mstr removed dependency issues

* fix session still active error

* py_format

* fix tests

* Addressed Comments

* Addressed Comments

* addressed comments

* Addressed comments

* Add constants

* Fix pytests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants