-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: mstr removed dependency issues #18732
Merged
SumanMaharana
merged 13 commits into
open-metadata:main
from
SumanMaharana:fix-mstr-api
Nov 22, 2024
Merged
Fix: mstr removed dependency issues #18732
SumanMaharana
merged 13 commits into
open-metadata:main
from
SumanMaharana:fix-mstr-api
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
Add this label to run secure Github workflows on PRs
labels
Nov 21, 2024
9 tasks
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
pmbrull
previously approved these changes
Nov 22, 2024
pmbrull
approved these changes
Nov 22, 2024
Quality Gate failed for 'open-metadata-ingestion'Failed conditions |
SumanMaharana
added a commit
that referenced
this pull request
Nov 22, 2024
* Fix: mstr removed dependency issues * fix session still active error * py_format * fix tests * Addressed Comments * Addressed Comments * addressed comments * Addressed comments * Add constants * Fix pytests
harshach
pushed a commit
that referenced
this pull request
Nov 24, 2024
* Fix: mstr removed dependency issues * fix session still active error * py_format * fix tests * Addressed Comments * Addressed Comments * addressed comments * Addressed comments * Add constants * Fix pytests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fix: mstr removed dependency issues
mstrio-py had lot of dependencies which do not align with other OSS entity
removed that dependency by using the requests lib
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>