Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: chore(data-quality): improve messaging for COUNT strategy failure #18884

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Dec 2, 2024

Describe your changes:

Align the error message with doocumentation.

Uploading image.png…

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner December 2, 2024 15:39
@sushi30 sushi30 changed the title chore(data-quality): improve messaging for COUNT strategy failure MINOR: chore(data-quality): improve messaging for COUNT strategy failure Dec 2, 2024
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 2, 2024
Copy link

sonarqubecloud bot commented Dec 3, 2024

@sushi30 sushi30 merged commit 416ba2c into main Dec 3, 2024
14 of 17 checks passed
@sushi30 sushi30 deleted the custom-sql-strategy-validation branch December 3, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants