MINOR - Clean up configs & add auto classification docs #18907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmbrull
requested review from
a team,
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
pmbrull
commented
Dec 3, 2024
| @@ -1745,7 +1745,7 @@ WHERE JSON_EXTRACT(json, '$.pipelineType') = 'metadata'; | |||
|
|
|||
| -- classification and sampling configs from the profiler pipelines | |||
| UPDATE ingestion_pipeline_entity | |||
| SET json = JSON_REMOVE(json, '$.sourceConfig.config.processPiiSensitive', '$.sourceConfig.config.confidence', '$.sourceConfig.config.generateSampleData') | |||
| SET json = JSON_REMOVE(json, '$.sourceConfig.config.processPiiSensitive', '$.sourceConfig.config.confidence', '$.sourceConfig.config.generateSampleData', '$.sourceConfig.config.sampleDataCount') | |||
There was a problem hiding this comment.
this is also not needed for the profiler. It was only used for sample data
github-actions
bot
added
Ingestion
safe to test
pmbrull
commented
Dec 3, 2024
| session = self.create_session() | ||
| if self.config.endPointURL is not None: | ||
| return session.client( | ||
| service_name=service_name, endpoint_url=str(self.config.endPointURL) | ||
| ) | ||
| return session.client(service_name=service_name) | ||
|
|
||
| logger.info(f"Getting AWS default client for service [{service_name}]") | ||
| logger.debug(f"Getting AWS default client for service [{service_name}]") |
There was a problem hiding this comment.
since we're now passing the client to the source externally, this log was too chatty
pmbrull
commented
Dec 3, 2024
| profile_sample_type=self.source_config.profileSampleType, | ||
| sampling_method_type=self.source_config.samplingMethodType, | ||
| ), | ||
| default_sample_config=SampleConfig(), |
There was a problem hiding this comment.
keeping simpler pipeline for the auto classification. If there's anything configured for the table we'll pick it from there directly
Jest test CoverageUI tests summary
|
|
sushi30
approved these changes
Dec 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>