Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15600: Retention Application : Delete change_events, activity threads, versions based on admin retention policies #18913

Merged
merged 23 commits into from
Jan 21, 2025
Merged

#15600: Retention Application : Delete change_events, activity threads, versions based on admin retention policies #18913

merged 23 commits into from
Jan 21, 2025

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Dec 4, 2024 •
edited
Loading

Describe your changes:

Fixes: #15600 #13526

Retention Policy App Diagram

Screenshot 2024-12-19 at 5 54 29 PM Screenshot 2024-12-19 at 5 54 09 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 4, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Dec 4, 2024
@Siddhanttimeline Siddhanttimeline marked this pull request as draft December 4, 2024 06:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.65% (40874/63220) 40.89% (16420/40153) 44.11% (4969/11266)

@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@Siddhanttimeline Siddhanttimeline added the To release Will cherry-pick this PR into the release branch label Jan 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Siddhanttimeline Siddhanttimeline enabled auto-merge (squash) January 21, 2025 12:39
@mohityadav766 mohityadav766 merged commit 4862308 into main Jan 21, 2025
39 of 50 checks passed
@mohityadav766 mohityadav766 deleted the retention-policy-app branch January 21, 2025 12:42
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
@Siddhanttimeline
#15600: Retention Application : Delete change_events, activity thread…
eef769f 
…s, versions based on admin retention policies (#18913)

* feat(retention-policy): initial setup of the Retention Policy app

* refactor: Update logic to make RetentionPolicyApp a ScheduledOrManual app

* refactor: Update retention policy JSON schema and logic to support event subscription, versions, and activity thread with individual retention periods

* refactor: Rename eventSubscriptionRetentionPeriod to changeEventRetentionPeriod

* fix: Implement activity thread retention policy cleanup

* chore: Remove activity thread and versions retention code; add banner and icon

(cherry picked from commit 4862308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushi30 sushi30 sushi30 approved these changes

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

@harshach harshach Awaiting requested review from harshach

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retention Application : Delete change_events, activity threads, versions based on admin retention policies
4 participants
@Siddhanttimeline @harshach @sushi30 @mohityadav766