Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Cockroach db connector #18961

Merged
merged 41 commits into from
Jan 2, 2025

Conversation

akashverma0786
Copy link
Contributor

@akashverma0786 akashverma0786 commented Dec 9, 2024

Describe your changes:

This PR introduces a new connector for CockroachDB integration with OpenMetadata. The connector enables metadata ingestion from CockroachDB databases into the OpenMetadata platform.

Short blurb explaining:

  • What changes did you make?

    • Implemented CockroachDB metadata ingestion functionality
    • Added integration and topology tests for the CockroachDB connector
    • Created example workflow YAML configuration file
    • Updated setup.py with required dependencies
    • Implemented necessary UI changes for connector configuration
  • How did you test your changes?

    • Added integration tests to verify connector functionality
    • Added topology test
    • Tested workflow execution with example YAML configuration and UI

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Screenshot 2024-12-13 at 12 28 54
Screenshot 2024-12-13 at 12 26 01

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

ayush-shah
ayush-shah previously approved these changes Dec 17, 2024
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link

sonarqubecloud bot commented Jan 2, 2025

@akashverma0786 akashverma0786 mentioned this pull request Jan 2, 2025
9 tasks
@ayush-shah ayush-shah merged commit 39dcb5b into open-metadata:main Jan 2, 2025
24 of 28 checks passed
@akashverma0786 akashverma0786 deleted the cockroach_db_connector branch January 18, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants